Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wiki translation into Romanian #50

Merged
merged 13 commits into from
Aug 10, 2024
Merged

Wiki translation into Romanian #50

merged 13 commits into from
Aug 10, 2024

Conversation

Douper2
Copy link
Contributor

@Douper2 Douper2 commented Aug 4, 2024

No description provided.

@Douper2
Add files via upload
fbddcf1 
translated all the files in Romanian

Signed-off-by: Douper <[email protected]>
@Douper2
Add files via upload
63fcbd5 
Translated all the files in Romanian

Signed-off-by: Douper <[email protected]>
@Douper2
Add files via upload
ffbb875 
Signed-off-by: Douper <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 4, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en docs/ro/contribute.md Source added, will be tracked.
en docs/ro/download.md Source added, will be tracked.
en docs/ro/emulation.md Source added, will be tracked.
en docs/ro/glossary.md Source added, will be tracked.
en docs/ro/index.md Source added, will be tracked.
en docs/ro/linux.md Source added, will be tracked.
en docs/ro/software.md Source added, will be tracked.
en docs/ro/unsafe.md Source added, will be tracked.
en docs/ro/useful.md Source added, will be tracked.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

taskylizard
taskylizard reviewed Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@taskylizard taskylizard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you going to translate the description fields?

@Douper2
Copy link
Contributor Author

Douper2 commented Aug 5, 2024

Are you going to translate the description fields?

I didn't think that it was necessary to translate that, but I will

@Douper2
Add files via upload
b44722c 
Signed-off-by: Douper <[email protected]>
@Douper2
Copy link
Contributor Author

Douper2 commented Aug 5, 2024

Are you going to translate the description fields?

I didn't think that it was necessary to translate that, but I will

Ok, I just changed thew description

@taskylizard
Copy link
Collaborator

I just noticed, you moved the files inside docs/ to the root of this project, I'll have to clean that up later.

Regarding description, yeah, it is needed for metadata tags as well as opengraph image generation, while you probably can skip doing this for now if you're busy.

I'll prepare the lunaria configuration files and related later today in your PR.

@taskylizard taskylizard self-assigned this Aug 5, 2024
@Douper2
Copy link
Contributor Author

Douper2 commented Aug 6, 2024

I just noticed, you moved the files inside docs/ to the root of this project, I'll have to clean that up later.

Regarding description, yeah, it is needed for metadata tags as well as opengraph image generation, while you probably can skip doing this for now if you're busy.

I'll prepare the lunaria configuration files and related later today in your PR.

Ok, also thanks for the notice about the description

@taskylizard
Copy link
Collaborator

You're now only left witb translating the sidebar.

@Douper2
Copy link
Contributor Author

Douper2 commented Aug 7, 2024

You're now only left witb translating the sidebar.

Where is the sidebar text?

@taskylizard
Copy link
Collaborator

docs/.vitepress/locales/ro.ts

@Douper2
Copy link
Contributor Author

Douper2 commented Aug 9, 2024

docs/.vitepress/locales/ro.ts

I translated the sidebar though

@taskylizard
Copy link
Collaborator

Nope, https://github.com/Douper2/wiki/blob/master/docs/.vitepress/locales/ro.ts, I committed the file myself for you.

@Douper2
Update ro.ts
5878f58 
Signed-off-by: Douper <[email protected]>
@Douper2
Copy link
Contributor Author

Douper2 commented Aug 9, 2024

Nope, https://github.com/Douper2/wiki/blob/master/docs/.vitepress/locales/ro.ts, I committed the file myself for you.

Most likely I forgot to upload the file containing the sidebar but now it's fixed

@taskylizard
Copy link
Collaborator

Thanks, I also now noticed that some pages still have their english fields (title, description), will you translate them?

@Douper2
Copy link
Contributor Author

Douper2 commented Aug 10, 2024

Thanks, I also now noticed that some pages still have their english fields (title, description), will you translate them?

No problem, I just finished translating the description

taskylizard
taskylizard approved these changes Aug 10, 2024
View reviewed changes
Copy link
Collaborator

@taskylizard taskylizard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good, thanks for the PR!

@taskylizard taskylizard merged commit 6666966 into privateersclub:master Aug 10, 2024
1 check passed
@Douper2
Copy link
Contributor Author

Douper2 commented Aug 14, 2024

I fixed another translation, could you merge it?

@taskylizard
Copy link
Collaborator

taskylizard commented Aug 14, 2024 •
edited
Loading

Make a new PR.

I looked at your fork and it is 20 commits behind, you can click the "Sync Fork" option to bring it up to latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taskylizard taskylizard taskylizard approved these changes

Assignees

@taskylizard taskylizard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Douper2 @taskylizard